Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds plasteel arming sword #887

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Conversation

MagnusCrowe
Copy link
Contributor

@MagnusCrowe MagnusCrowe commented Jan 16, 2024

About the PR

New melee weapon. Shout out to the Oni.

Technical details

1.5 swing speed.
15 slash.

Media

image

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 MagnusCrowe

  • add: Added plasteel arming sword!

Copy link
Contributor

github-actions bot commented Jan 16, 2024

RSI Diff Bot; head commit 44ba4c7 merging into 382e24d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Melee/armingsword.rsi

State Old New Status
equipped-BACKPACK Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 44ba4c7

@MagnusCrowe MagnusCrowe changed the title Adds plasteel broadsword Adds plasteel arming sword Jan 16, 2024
@GentleButter
Copy link

Given that Oni players need more melee options (especially with potential removal of gun use entirely?) i support and endorse this

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Sword sprite look very close to another sword.

@dvir001
Copy link
Contributor

dvir001 commented Jan 16, 2024

Please base it on another sword as perent and not baseitem since it's going to be harder to support with grid bullshit

If there is a sword that is also 15 base it from it

@MagnusCrowe
Copy link
Contributor Author

Please base it on another sword as perent and not baseitem since it's going to be harder to support with grid bullshit

If there is a sword that is also 15 base it from it

That might be a larger issue...almost all the swords seem to use BaseItem as their parent...except the energy katana.

@MagnusCrowe
Copy link
Contributor Author

MagnusCrowe commented Jan 16, 2024

This Sword sprite look very close to another sword.

Are you referring to the claymore? The Icon for the sword is in the same style as the claymore to keep art style's consistent but everything else is completely different (and higher quality IMO).
image

@MagnusCrowe
Copy link
Contributor Author

Please base it on another sword as perent and not baseitem since it's going to be harder to support with grid bullshit

If there is a sword that is also 15 base it from it

Done.

@YumiGumi
Copy link
Contributor

As an Oni, I approve these changes and have some ideas of my own I am working on spriting.

@Cheackraze
Copy link
Member

Looks like 'Sword' isn't a tag yet. You can either remove the tag (it seems unused) or add the tag prototype in the appropriate file and then this is good to merge

@MagnusCrowe
Copy link
Contributor Author

Looks like 'Sword' isn't a tag yet. You can either remove the tag (it seems unused) or add the tag prototype in the appropriate file and then this is good to merge

Dvir took care of it

@dvir001
Copy link
Contributor

dvir001 commented Jan 21, 2024

No errors all good

@ErhardSteinhauer
Copy link
Contributor

ErhardSteinhauer commented Jan 21, 2024

Also while you at it, can you add this tag WeaponMelee so the new sword could be stored in melee weapon racks?

@ErhardSteinhauer
Copy link
Contributor

Also while you at it, can you add this tag WeaponMelee so the new sword could be stored in melee weapon racks?

Oh, my bad, it's there

@dvir001 dvir001 merged commit 51f42e5 into new-frontiers-14:master Jan 22, 2024
12 of 13 checks passed
FrontierATC added a commit that referenced this pull request Jan 22, 2024
@MagnusCrowe MagnusCrowe deleted the mastermaster branch February 9, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants