-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds plasteel arming sword #887
Conversation
RSI Diff Bot; head commit 44ba4c7 merging into 382e24d Resources/Textures/_NF/Objects/Weapons/Melee/armingsword.rsi
|
Given that Oni players need more melee options (especially with potential removal of gun use entirely?) i support and endorse this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Sword sprite look very close to another sword.
Please base it on another sword as perent and not baseitem since it's going to be harder to support with grid bullshit If there is a sword that is also 15 base it from it |
That might be a larger issue...almost all the swords seem to use BaseItem as their parent...except the energy katana. |
Done. |
As an Oni, I approve these changes and have some ideas of my own I am working on spriting. |
Looks like 'Sword' isn't a tag yet. You can either remove the tag (it seems unused) or add the tag prototype in the appropriate file and then this is good to merge |
Dvir took care of it |
No errors all good |
Also while you at it, can you add this tag |
Oh, my bad, it's there |
About the PR
New melee weapon. Shout out to the Oni.
Technical details
1.5 swing speed.
15 slash.
Media
Breaking changes
Changelog
🆑 MagnusCrowe